On Sat, 14 Nov 2020 23:04:41 +0100
Andreas Färber <afaerber@xxxxxxx> wrote:
Hi Andreas,
> > - phy1: phy@1 {
> > + phy1: ethernet-phy@1 {
>
> This one I had noticed in the DT binding and verified that mainline
> U-Boot does not rely on it. So ACK for this.
>
> > status = "okay";
>
> Unrelated: This property is theoretically superfluous, as unlike eth2
> this node is new and doesn't overwrite a pre-existing property.
Yes, status = "okay" is not needed if there isn't status = "disabled"
before (somewhere in include files). Maybe I will send a patch removing
all unneeded status="okay" properties in the future.
> I believe in my testing overriding with status = "disabled" was not
> enough to get the SFP to work, I needed to comment out the referencing
> phy(-handle) property.
Yes, as I wrote in reply to your question in patch 4/6, U-Boot needs to:
- remove phy-handle property
- add managed = in-band-status property
- enable sfp node
>
> > - compatible = "ethernet-phy-id0141.0DD1", "ethernet-phy-ieee802.3-c22";
> > + compatible = "ethernet-phy-ieee802.3-c22";
>
> Does it do any harm to leave it in though?
No, but lets remove it anyway :)
Marek
