On 14.11.20 22:36, Andreas Färber wrote:
> Hi Marek,
>
> On 14.11.20 19:32, Marek Behún wrote:
>> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
>> index 7ccebf7d1757..14c21cddef72 100644
>> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
>> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
>> @@ -82,6 +82,22 @@ pcie@3,0 {
>> };
>> };
>> };
>> +
>> + sfp: sfp {
>> + compatible = "sff,sfp";
>> + i2c-bus = <&sfp_i2c>;
>> + tx-fault-gpios = <&pcawan 0 GPIO_ACTIVE_HIGH>;
>> + tx-disable-gpios = <&pcawan 1 GPIO_ACTIVE_HIGH>;
>> + rate-select0-gpios = <&pcawan 2 GPIO_ACTIVE_HIGH>;
>> + los-gpios = <&pcawan 3 GPIO_ACTIVE_HIGH>;
>> + mod-def0-gpios = <&pcawan 4 GPIO_ACTIVE_LOW>;
>> +
>> + /*
>> + * For now this has to be enabled at boot time by U-Boot when
>> + * a SFP module is present.
>> + */
>> + status = "disabled";
>> + };
>> };
>>
>> &bm {
>> @@ -130,6 +146,7 @@ ð2 {
>> phy-mode = "sgmii";
>> phy = <&phy1>;
>> phys = <&comphy5 2>;
>> + sfp = <&sfp>;
>> buffer-manager = <&bm>;
>> bm,pool-long = <2>;
>> bm,pool-short = <3>;
>> @@ -195,7 +212,7 @@ i2c@3 {
>> /* routed to PCIe2 connector (CN62A) */
>> };
>>
>> - i2c@4 {
>> + sfp_i2c: i2c@4 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> reg = <4>;
>
> Matches what I've come up with,
Actually one minor diff: As I had pointed out to you privately before, I
set maximum-power-milliwatt to its max of 2000.
Does your hardware only support the default of 1000, or are you still
unsure of the limit that you've omitted it here? Not sure if it makes a
difference in practice, but it does show up in dmesg.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
