Hi Marek,
On 14.11.20 19:32, Marek Behún wrote:
> Use property name `phy-handle` instead of the deprecated `phy` to
> connect eth2 to the PHY.
> Rename the node from "phy@1" to "ethernet-phy@1", since "phy@1" is
> incorrect according to device-tree bindings documentation.
> Also remove the "ethernet-phy-id0141.0DD1" compatible string, it is not
> needed. Kernel can read the PHY identifier itself.
>
> Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Cc: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> Cc: Andreas Färber <afaerber@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index df53cf925db6..694d69798685 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -145,7 +145,7 @@ fixed-link {
> ð2 {
> status = "okay";
> phy-mode = "sgmii";
> - phy = <&phy1>;
> + phy-handle = <&phy1>;
> phys = <&comphy5 2>;
> sfp = <&sfp>;
> buffer-manager = <&bm>;
> @@ -374,9 +374,9 @@ &mdio {
> pinctrl-0 = <&mdio_pins>;
> status = "okay";
>
> - phy1: phy@1 {
> + phy1: ethernet-phy@1 {
This one I had noticed in the DT binding and verified that mainline
U-Boot does not rely on it. So ACK for this.
> status = "okay";
Unrelated: This property is theoretically superfluous, as unlike eth2
this node is new and doesn't overwrite a pre-existing property.
I believe in my testing overriding with status = "disabled" was not
enough to get the SFP to work, I needed to comment out the referencing
phy(-handle) property.
> - compatible = "ethernet-phy-id0141.0DD1", "ethernet-phy-ieee802.3-c22";
> + compatible = "ethernet-phy-ieee802.3-c22";
Does it do any harm to leave it in though?
> reg = <1>;
>
> /* irq is connected to &pcawan pin 7 */
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
