Hi Ricardo,
On 5/10/20 11:18, Ricardo Cañuelo wrote:
> Hi Enric, thanks for reviewing the patch.
>
> On lun 05-10-2020 10:52:26, Enric Balletbo i Serra wrote:
>>> +examples:
>>> + - |
>>> + cros-ec {
>>
>> We try to use always a complete example, and I think that, Rob also prefers
>> complete examples, so here you are missing the spi node.
>
> Ok, I'll prepare a new patch with an extended example.
>
>>> + compatible = "google,cros-ec-spi";
>>
>> And, at least, should have a reg. Did not give you an error?
>
> AFAIK, the reg property is only enforced if the node name includes the
> unit-address.
>
Exactly, and because this is a spi driver it should have both, the node name
include the unit-address and the reg property. I.e:
spi0 {
#address-cells = <1>;
#size-cells = <0>;
cros-ec@0 {
compatible = "google,cros-ec-spi";
reg = <0x0>;
spi-max-frequency = <5000000>;
};
};
Thanks,
Enric
> Cheers,
> Ricardo
>
