Re: [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Enric, thanks for reviewing the patch.

On lun 05-10-2020 10:52:26, Enric Balletbo i Serra wrote:
> > +examples:
> > +  - |
> > +    cros-ec {
> 
> We try to use always a complete example, and I think that, Rob also prefers
> complete examples, so here you are missing the spi node.

Ok, I'll prepare a new patch with an extended example.

> > +        compatible = "google,cros-ec-spi";
> 
> And, at least, should have a reg. Did not give you an error?

AFAIK, the reg property is only enforced if the node name includes the
unit-address.

Cheers,
Ricardo



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux