Hi Ricardo, Many thanks to work on this. Just a few comment below. On 5/10/20 9:14, Ricardo Cañuelo wrote: > Convert the google,cros-ec-i2c-tunnel binding to YAML. > > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@xxxxxxxxxxxxx> > --- > .../i2c/google,cros-ec-i2c-tunnel.yaml | 56 +++++++++++++++++++ > .../bindings/i2c/i2c-cros-ec-tunnel.txt | 39 ------------- > 2 files changed, 56 insertions(+), 39 deletions(-) > create mode 100644 Documentation/devicetree/bindings/i2c/google,cros-ec-i2c-tunnel.yaml > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.txt > > diff --git a/Documentation/devicetree/bindings/i2c/google,cros-ec-i2c-tunnel.yaml b/Documentation/devicetree/bindings/i2c/google,cros-ec-i2c-tunnel.yaml > new file mode 100644 > index 000000000000..905dbc788dc0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/google,cros-ec-i2c-tunnel.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/i2c/google,cros-ec-i2c-tunnel.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: I2C bus that tunnels through the ChromeOS EC (cros-ec) > + > +maintainers: > + - Doug Anderson <dianders@xxxxxxxxxxxx> > + - Benson Leung <bleung@xxxxxxxxxxxx> > + - Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > + > +description: | > + On some ChromeOS board designs we've got a connection to the EC > + (embedded controller) but no direct connection to some devices on the > + other side of the EC (like a battery and PMIC). To get access to > + those devices we need to tunnel our i2c commands through the EC. > + > + The node for this device should be under a cros-ec node like > + google,cros-ec-spi or google,cros-ec-i2c. > + > +properties: > + compatible: > + const: google,cros-ec-i2c-tunnel > + > + google,remote-bus: > + description: The EC bus we'd like to talk to. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +required: > + - compatible > + - google,remote-bus > + > +unevaluatedProperties: false > + > +examples: > + - | > + cros-ec { We try to use always a complete example, and I think that, Rob also prefers complete examples, so here you are missing the spi node. > + compatible = "google,cros-ec-spi"; And, at least, should have a reg. Did not give you an error? > + > + i2c-tunnel { > + compatible = "google,cros-ec-i2c-tunnel"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + google,remote-bus = <0>; > + > + battery: sbs-battery@b { > + compatible = "sbs,sbs-battery"; > + reg = <0xb>; > + sbs,poll-retry-count = <1>; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.txt b/Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.txt > deleted file mode 100644 > index 898f030eba62..000000000000 > --- a/Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.txt > +++ /dev/null > @@ -1,39 +0,0 @@ > -I2C bus that tunnels through the ChromeOS EC (cros-ec) > -====================================================== > -On some ChromeOS board designs we've got a connection to the EC (embedded > -controller) but no direct connection to some devices on the other side of > -the EC (like a battery and PMIC). To get access to those devices we need > -to tunnel our i2c commands through the EC. > - > -The node for this device should be under a cros-ec node like google,cros-ec-spi > -or google,cros-ec-i2c. > - > - > -Required properties: > -- compatible: google,cros-ec-i2c-tunnel > -- google,remote-bus: The EC bus we'd like to talk to. > - > -Optional child nodes: > -- One node per I2C device connected to the tunnelled I2C bus. > - > - > -Example: > - cros-ec@0 { > - compatible = "google,cros-ec-spi"; > - > - ... > - > - i2c-tunnel { > - compatible = "google,cros-ec-i2c-tunnel"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - google,remote-bus = <0>; > - > - battery: sbs-battery@b { > - compatible = "sbs,sbs-battery"; > - reg = <0xb>; > - sbs,poll-retry-count = <1>; > - }; > - }; > - } >
