Hi Ricardo, Thank you to work on this. On 5/10/20 9:14, Ricardo Cañuelo wrote: > Add missing properties that are currently used in the examples of > subnode bindings and in many DTs. > This fixes all current dt_binding_check and dtbs_check warnings related > to this binding. > > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@xxxxxxxxxxxxx> > --- > .../bindings/mfd/google,cros-ec.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index f49c0d5d31ad..c2dc05cdef9f 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -59,18 +59,58 @@ properties: > whether this nvram is present or not. > type: boolean > > + mtk,rpmsg-name: AFAIK mtk is not a valid vendor prefix (vendor-prefixes.yaml), so I am wondering if this should be mediatek,rpmsg-name. I see this being used in drivers/rpmsg/mtk_rpmsg.c file, but there isn't a devitree using it. So maybe we're on time to fix it. Thanks, Enric > + description: > + Must be defined if the cros-ec is a rpmsg device for a Mediatek > + ARM Cortex M4 Co-processor. Contains the name pf the rpmsg > + device. Used to match the subnode to the rpmsg device announced by > + the SCP. > + $ref: /schemas/types.yaml#/definitions/string > + > spi-max-frequency: > description: Maximum SPI frequency of the device in Hz. > > reg: > maxItems: 1 > > + '#address-cells': > + enum: [1, 2] > + > + '#size-cells': > + enum: [0, 1] > + > interrupts: > maxItems: 1 > > wakeup-source: > description: Button can wake-up the system. > > + typec: > + $ref: "/schemas/chrome/google,cros-ec-typec.yaml#" > + > + ec-pwm: > + $ref: "/schemas/pwm/google,cros-ec-pwm.yaml#" > + > + keyboard-controller: > + $ref: "/schemas/input/google,cros-ec-keyb.yaml#" > + > +patternProperties: > + "^regulator@[a-f0-9]+$": > + type: object > + $ref: "/schemas/regulator/google,cros-ec-regulator.yaml#" > + > + "^extcon[0-9]*$": > + type: object > + $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#" > + > + "^ec-codec@[a-f0-9]+$": > + type: object > + $ref: "/schemas/sound/google,cros-ec-codec.yaml#" > + > + "^i2c-tunnel[0-9]*$": > + type: object > + $ref: "/schemas/i2c/google,cros-ec-i2c-tunnel.yaml#" > + > required: > - compatible > >
