Hi Enric, Thank you for reviewing On lun 05-10-2020 11:23:15, Enric Balletbo i Serra wrote: > > + mtk,rpmsg-name: > > AFAIK mtk is not a valid vendor prefix (vendor-prefixes.yaml), so I am wondering > if this should be mediatek,rpmsg-name. I see this being used in > drivers/rpmsg/mtk_rpmsg.c file, but there isn't a devitree using it. So maybe > we're on time to fix it. It is used in arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi. I'm not sure if defining this kind of vendor-specific properties in google,cros-ec is the right approach, but I can't think of a better alternative (any suggestion is welcome). I thought about making this conditional to the "compatible" string but in the case of mt8183-kukui.dtsi the string looks too generic for it to be associated with a particular vendor. Shall I go and fix the vendor prefix in all places (driver, binding and DT)? Cheers, Ricardo
