Hi Vivek, On 3/13/20 3:20 PM, Vivek Unune wrote: > On Fri, Mar 13, 2020 at 09:32:27AM +0100, Johan Jonker wrote: >> Hi Vivek, >> >> The 'power-led' need some changes. >> >> From leds-gpio.yaml: >> >> patternProperties: >> # The first form is preferred, but fall back to just 'led' anywhere in the >> # node name to at least catch some child nodes. >> "(^led-[0-9a-f]$|led)": >> type: object >> >> Test with: >> make -k ARCH=arm64 dtbs_check >> >> arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dt.yaml: leds: >> power-led:linux,default-trigger:0: 'none' is not one of ['backlight', >> 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] >> >> On 3/13/20 1:01 AM, Vivek Unune wrote: >>> - Add Hugsun X99 IR receiver and power led >>> - Remove pwm0 node as it interferes with pwer LED gpio >> >> pwer => power >> > > Hi Johan, > > I'll fix those in my next version. Here's what I intended to to: > > 1. Rename 'power-led' node to 'led-power' The first form is preferred. Put 'led-power' in a regex tester with ^led-[0-9a-f]$ https://regex101.com/ Your regular expression does not match the subject string. Test 'led-0' Full match > 2. Remove 'linux,default-trigger' entirely since this led is always on > > Thanks, > > Vivek > >>> index d69a613fb65a..df425e164a2e 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts >>> @@ -29,6 +29,26 @@ >>> regulator-max-microvolt = <5000000>; >>> }; >>> >>> + leds { >>> + compatible = "gpio-leds"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&power_led_gpio>; >>> + >>> + power-led { >>> + label = "blue:power"; >>> + gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_HIGH>; >>> + default-state = "on"; >>> + linux,default-trigger = "none"; >>> + }; >>> + }; >>> +
