On Fri, Feb 28, 2020 at 3:29 AM Peter Chen <peter.chen@xxxxxxx> wrote:
>
>
> > > .../bindings/phy/cdns,salvo-phy.yaml | 47 +++++++++++++++++++
> > > 1 file changed, 47 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > warning: no schema found in file:
> > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
> > /builds/robherring/linux-dt-
> > review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: ignoring, error
> > parsing file
> > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-
> > 37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be
> > at root node
> > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: while scanning a
> > block scalar
> > in "<unicode string>", line 39, column 5 found a tab character where an indentation
> > space is expected
> > in "<unicode string>", line 41, column 1
> > Documentation/devicetree/bindings/Makefile:12: recipe for target
> > 'Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts' failed
> > make[1]: *** [Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts]
> > Error 1
> > Makefile:1263: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> >
> Hi Rob,
>
> After changing some format, I still got below errors, would you please point to
> what's wrong with line 40, column 12? Thanks.
It is line numbers of the generated .example.dts you need to look at.
>
> 31 required:
> 32 - compatible
> 33 - reg
> 34 - "#phy-cells"
> 35
> 36 additionalProperties: false
> 37
> 38 examples:
> 39 -|
> 40 usb3phy: usb3-phy {
Needs a unit address.
> 41 compatible = "nxp,salvo-phy";
> 42 reg = <0x5B160000 0x40000>;
> 43 clocks = <&usb3_lpcg 4>;
> 44 clock-names = "salvo_phy_clk";
> 45 power-domains = <&pd IMX_SC_R_USB_2_PHY>;
Need to include the header for this define.
> 46 #phy-cells = <0>;
> 47 };
