> > .../bindings/phy/cdns,salvo-phy.yaml | 47 +++++++++++++++++++ > > 1 file changed, 47 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > warning: no schema found in file: > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: ignoring, error > parsing file > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16- > 37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be > at root node > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: while scanning a > block scalar > in "<unicode string>", line 39, column 5 found a tab character where an indentation > space is expected > in "<unicode string>", line 41, column 1 > Documentation/devicetree/bindings/Makefile:12: recipe for target > 'Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts] > Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > Hi Rob, After changing some format, I still got below errors, would you please point to what's wrong with line 40, column 12? Thanks. 31 required: 32 - compatible 33 - reg 34 - "#phy-cells" 35 36 additionalProperties: false 37 38 examples: 39 -| 40 usb3phy: usb3-phy { 41 compatible = "nxp,salvo-phy"; 42 reg = <0x5B160000 0x40000>; 43 clocks = <&usb3_lpcg 4>; 44 clock-names = "salvo_phy_clk"; 45 power-domains = <&pd IMX_SC_R_USB_2_PHY>; 46 #phy-cells = <0>; 47 }; make[1]: Entering directory '/home/b29397/work/projects/upstream/usb/outout/imx_v8' CHKDT Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml /home/b29397/work/projects/upstream/usb/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: mapping values are not allowed in this context in "<unicode string>", line 40, column 12 /home/b29397/work/projects/upstream/usb/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts' failed make[2]: *** [Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dts] Error 1 /home/b29397/work/projects/upstream/usb/Makefile:1262: recipe for target 'dt_binding_check' failed make[1]: *** [dt_binding_check] Error 2 make[1]: Leaving directory '/home/b29397/work/projects/upstream/usb/outout/imx_v8' Makefile:179: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Peter