On 4/26/19 1:07 AM, Rob Herring wrote: > On Wed, Apr 24, 2019 at 4:54 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >> >> On 4/24/19 11:23 PM, Rob Herring wrote: >>> On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: >>>> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. >>>> >>>> Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 40 ++++++++++++++++++++++ >>>> 1 file changed, 40 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >>>> new file mode 100644 >>>> index 0000000..668b822 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >>>> @@ -0,0 +1,40 @@ >>>> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings >>>> +-------------------------------------------------- >>> >>> Looks like a SPI flash controller from the example. What makes it an >>> MFD? >> >> It supports both SPI NOR and HyperFlash (CFI-compliant flash with >> different bus interface). > > Not sure that really makes it an MFD. Lee probably has an opinion. > > In any case, can we get a complete binding that shows both. Presumably that would only mean the flash compatible is some "cfi,nor" or somesuch. But I agree, would be nice to have both in the example. -- Best regards, Marek Vasut