On Mon, Feb 24, 2014 at 09:48:10AM +0800, Shawn Guo wrote: > Update fsl-fec.txt to add 'clocks' and 'clock-names' properties. > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > Changes since v1: > - Leave compatible change out, which should probably be addressed by > another patch > - Move clock properties into 'Optional properties:' section As mentioned in the reply to v1: Marking the clocks as optional doesn't make sense when the driver actually requires them (Or be prepared when somebody sends in a patch 'fixing' the driver according to the binding). IMO we should just mention the clocks are optional on PowerPC. Sascha > > Documentation/devicetree/bindings/net/fsl-fec.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > index 845ff84..468736d 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -16,6 +16,15 @@ Optional properties: > will have the duration be 1 millisecond. Numbers greater than 1000 are > invalid and 1 millisecond will be used instead. > - phy-supply: regulator that powers the Ethernet PHY. > +- clocks: the clocks feeding the FEC controller and phy. > + - "ipg": the peripheral access clock > + - "ahb": the bus clock for MAC > + - "ptp": the sampling clock for PTP (IEEE 1588). On SoC like i.MX6Q, > + the clock could come from either the internal clock control module > + or external oscillator via pad depending on board design. > + - "enet_out": the phy reference clock provided by SoC via pad, which > + is available on SoC like i.MX28. > +- clock-names: Must contain the clock names described just above > > Example: > > -- > 1.7.9.5 > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
