Hi Geert, On Mon, Feb 24, 2014 at 4:39 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Magnus, > > On Mon, Feb 24, 2014 at 3:45 AM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: >> On Fri, Feb 21, 2014 at 1:13 AM, Geert Uytterhoeven >> <geert@xxxxxxxxxxxxxx> wrote: >>> On Thu, Feb 20, 2014 at 4:41 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: >>>> On thing stuck out a bit with the bindings. I can see that you specify >>>> both fifo size and use the SoC suffix for the r8a7790 and r8a7791 >>>> bindings. Isn't that a bit of redundant information there, if we know >>>> that the SoC is r8a7790 or r8a7791 then can't we simply put that >>>> information in r8a779x_data above and perhaps keep the binding >>>> simpler? Perhaps same thing applies to other properties as well? >>> >>> "renesas,tx-fifo-size" and "renesas,rx-fifo-size" are part of the existing >>> bindings, so I'm a bit reluctant to change these. >>> Hmm, since the original bindings didn't specify the default values, >>> I could make them chip-specific, though. >> >> Thanks, yes I think treating the "renesas,tx-fifo-size" and >> "renesas,rx-fifo-size" bindings as optional and allow us to rely on >> chip-specific default values makes sense. >> >>> The only other property is "num-cs", which can have any value if you >>> start using the generic "cs-gpios". >> >> I see. It looks to me that such a setting is board-specific, so what >> is a sane default in the SoC DTSI? You seem to have it set to "1" >> today, but if the board is supposed to override it anyway then do we >> need to set it? >> >> Anyway, "num-cs" is a minor detail so no need to bother about that too much! > > In v2, I'll drop the "num-cs" from the dtsi, so it will default to the driver's > default (which is 1, for the simple case of using hardware controlled CS). Sounds good, thanks for your help! / magnus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
