On Thu, Feb 20, 2014 at 4:41 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > On thing stuck out a bit with the bindings. I can see that you specify > both fifo size and use the SoC suffix for the r8a7790 and r8a7791 > bindings. Isn't that a bit of redundant information there, if we know > that the SoC is r8a7790 or r8a7791 then can't we simply put that > information in r8a779x_data above and perhaps keep the binding > simpler? Perhaps same thing applies to other properties as well? "renesas,tx-fifo-size" and "renesas,rx-fifo-size" are part of the existing bindings, so I'm a bit reluctant to change these. Hmm, since the original bindings didn't specify the default values, I could make them chip-specific, though. The only other property is "num-cs", which can have any value if you start using the generic "cs-gpios". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html