On Mon, Feb 24, 2014 at 08:53:37AM +0100, Sascha Hauer wrote: > On Mon, Feb 24, 2014 at 09:48:10AM +0800, Shawn Guo wrote: > > Update fsl-fec.txt to add 'clocks' and 'clock-names' properties. > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > --- > > Changes since v1: > > - Leave compatible change out, which should probably be addressed by > > another patch > > - Move clock properties into 'Optional properties:' section > > As mentioned in the reply to v1: Marking the clocks as optional doesn't > make sense when the driver actually requires them (Or be prepared when > somebody sends in a patch 'fixing' the driver according to the binding). > IMO we should just mention the clocks are optional on PowerPC. Okay, the whole thing becomes quite uncertain to me. The reason of this v2 is that I got reminded by Gerhard's comment that we've had a time the driver works with DT without these properties. At that time, the clock driver provides the clock lookups for the device by calling clk_register_clkdev(). But on the other hand, I agree with you that it does not make sense to binding users, because the IP requires these clock inputs when it gets integrated on a SoC, and the driver requires these clocks to work. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
