On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx> > CC: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> > Reviewed-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > Tested-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> > Tested-by: Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> Already applied this patch, sorry for missing the resend in the series. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html