Hello.
> On 11/29/2013 11:54 PM, Alexander Shiyan wrote:
> > This patch adds a watchdog driver for devices controlled through GPIO,
> > (Analog Devices ADM706, Maxim MAX823, National NE555 etc).
> >
> > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> > ---
>
> Looks pretty good, except for a single nitpick below (sorry I didn't notice that one earlier).
>
> Also, as mentioned before, a changelog describing what changed and what didn't
> would be really helpful.
Just fixed all observations made by you earlier.
...
> > + /* Disallow values lower than 2 and higher than 65535 ms */
> > + if ((hw_margin < 2) || (hw_margin > 65535))
>
> Unnecessary ( ).
This can be corrected during merge. Isn't it? Or you expect v4?
Thanks.
---
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
