On Sun, Dec 01, 2013 at 11:03:27PM +0400, Alexander Shiyan wrote: > Hello. > > > On 11/29/2013 11:54 PM, Alexander Shiyan wrote: > > > This patch adds a watchdog driver for devices controlled through GPIO, > > > (Analog Devices ADM706, Maxim MAX823, National NE555 etc). > > > > > > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx> > > > --- > > > > Looks pretty good, except for a single nitpick below (sorry I didn't notice that one earlier). > > > > Also, as mentioned before, a changelog describing what changed and what didn't > > would be really helpful. > > Just fixed all observations made by you earlier. > Yes, but since you did not say that, I had to look up my earlier comments and check against this version. This takes time, and time is one thing which reviewers or subsystem maintainers don't always have readily available. > ... > > > + /* Disallow values lower than 2 and higher than 65535 ms */ > > > + if ((hw_margin < 2) || (hw_margin > 65535)) > > > > Unnecessary ( ). > > This can be corrected during merge. Isn't it? Or you expect v4? > If I were the watchdog maintainer, yes. Since I am not, it really depends on Wim. He might accept your patch as-is, make the change himself, expect you to submit another version, or request additional changes. You'll see. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
