On 11/29/2013 04:49 AM, Thierry Reding wrote: > On Fri, Nov 15, 2013 at 01:53:56PM -0700, Stephen Warren wrote: > [...] >> @@ -60,6 +81,12 @@ of the following host1x client modules: - >> compatible: "nvidia,tegra<chip>-dc" - reg: Physical base address >> and length of the controller's registers. - interrupts: The >> interrupt outputs from the controller. + - clocks : Must contain >> an entry for each entry in clock-names. + See >> ../clocks/clock-bindings.txt for details. + - clock-names : Must >> include the following entries: + - disp1 or disp2 (depending >> on the controller instance) > > I'm not sure if this makes sense. The name could be the same > independent of which controller uses it. If it isn't then the > driver would need additional code to find out which instance it is > and construct a dynamic string. > > Any objection to just make this entry "disp", or "dc"? This patch simply documents the binding that the various drivers already require and/or whatever is already in the DT files if there are any clocks the drivers don't currently use. I did consider fixing up all the current usage to actually be sane, but that would require even more driver changes (in addition to those required for the reset framework patches). >> + - clock-names : Must include the following entries: > > One other thing I noticed here is that you use a space between the > property name and the :. None of the other properties have that, so > it looks somewhat out of place. The same is true for other > bindings, but there seem to be inconsistencies in some places > anyway, so perhaps we don't care? Well, I do care, don't know about > you. =) Yes, I simply cut/paste the clock docs from one binding into the other to make sure the wording was consistent. I guess I need to go through and adjust the pasted format to match the various bindings. It's a pity they're plain-text not a schema, so there is no consistency here:-( >> diff --git >> a/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt >> b/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt >> index 91ff771c7e77..d4f2d534934b 100644 --- >> a/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt >> +++ >> b/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt >> @@ -6,8 +6,10 @@ Required properties: - interrupts: Should >> contain SPI interrupts. - nvidia,dma-request-selector : The Tegra >> DMA controller's phandle and request selector for this SPI >> controller. -- This is also require clock named "spi" as per >> binding document - >> Documentation/devicetree/bindings/clock/clock-bindings.txt +- >> clocks : Must contain an entry for each entry in clock-names. + >> See ../clocks/clock-bindings.txt for details. +- clock-names : >> Must include the following entries: + - spi > > This is inconsistent with other bindings that require only a > single clock entry. I suppose that this is required because of the > driver requesting a specifically named clock, in which case that's > fine. This driver does clk_get(dev, "spi") rather than clk_get(dev, NULL), so this requires a specific name. Again, I did consider updating all drivers to use names, but decided I didn't want to do even more driver changes, but instead just document what was currently required. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
