Re: [PATCH 2/3] ARM: dts: msm8974-hammerhead: Add regulator nodes for hammerhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sun, Jul 17, 2016 at 8:34 PM, Bhushan Shah <bshah@xxxxxxx> wrote:
> On Sun, Jul 17, 2016 at 09:21:48PM +0200, Arnd Bergmann wrote:
>> On Sunday, July 17, 2016 4:22:07 PM CEST Bhushan Shah wrote:
>> > +
>> > +       smd {
>> > +               rpm {
>> > +                       rpm_requests {
>> > +                               pm8841-regulators {
>> > +                                       s1 {
>> > +                                               regulator-min-microvolt = <675000>;
>> > +                                               regulator-max-microvolt = <1050000>;
>> > +                                       };
>>
>> Maybe add a label at either the rpm_requests or the pm8841-regulators
>> node so you can add properties in the leaf nodes withoutout having to
>> specify the whole path?
>
> Sure, I will adjust patch.

Please don't. After running into several cases where this would end us
up in having a multitude of nodes each describing just a snippet of
each level we decided not to do so in the general case for the
Qualcomm boards.

There are a few where we apparently ended up doing so anyways, but for
all other cases of regulators we express the full tree in the dts, so
please follow that so we don't mix the styles too much.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux