Re: [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Apr 20, 2016 at 01:12:36PM +0200, Geert Uytterhoeven wrote:
> Hi Martin,
> 
> On Wed, Apr 20, 2016 at 1:06 PM, Martin Sperl <kernel@xxxxxxxxxxxxxxxx> wrote:
> > On 20.04.2016 08:51, Geert Uytterhoeven wrote:
> >>
> >> On Mon, Apr 11, 2016 at 3:29 PM,  <kernel@xxxxxxxxxxxxxxxx> wrote:
> >>>
> >>> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> >>>
> >>> Use platform_get_irq_byname to allow for correct mapping of
> >>> interrupts to dma channels.
> >>>
> >>> The currently implemented device tree is unfortunately
> >>> implemented with the wrong assumption, that each dma-channel
> >>> has its own dma channel, but dma-irq 11 is handling
> >>> dma-channel 11-14 and dma-irq 12 is actually a "catch all"
> >>> interrupt.
> >>>
> >>> So here we use the byname variant and require that interrupts
> >>> are explicitly named via the interrupts-name property in the
> >>
> >> interrupt-names

well spotted

> >
> > Vinod has just merged this patch - do you want me to submit another
> 
> Yeah, that's how I noticed by accident :-)
> 
> > to correct those?
> 
> For the commit message it's indeed too late. For the error message in the
> code, yes please.

I can drop the branch

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux