* Franklin S Cooper Jr. <fcooper@xxxxxx> [160317 08:55]: > > > On 03/17/2016 10:11 AM, Rob Herring wrote: > > On Mon, Mar 07, 2016 at 07:23:44PM -0600, Franklin S Cooper Jr wrote: > >> From: Vignesh R <vigneshr@xxxxxx> > >> > >> Add PWMSS device tree nodes for DRA7 SoC family and add documentation > >> for dt bindings. > >> > >> Signed-off-by: Vignesh R <vigneshr@xxxxxx> > >> [fcooper@xxxxxx: Add eCAP and use updated bindings for PWMSS and ePWM] > >> Signed-off-by: Franklin S Cooper Jr <fcooper@xxxxxx> > >> --- > >> Version 5 changes: > >> Add DT node for eCAP and update eCAP binding documentation > >> > >> Version 4 changes: > >> Updated link to the latest documentation > >> > >> .../devicetree/bindings/pwm/pwm-tiecap.txt | 9 +++ > >> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 9 +++ > >> .../devicetree/bindings/pwm/pwm-tipwmss.txt | 15 +++- > >> arch/arm/boot/dts/dra7.dtsi | 84 ++++++++++++++++++++++ > >> 4 files changed, 116 insertions(+), 1 deletion(-) > > > >> + ehrpwm1: pwm@48440200 { > >> + compatible = "ti,dra7xx-ehrpwm", > >> + "ti,am33xx-ehrpwm"; > >> + #pwm-cells = <3>; > >> + reg = <0x48440200 0x80>; > >> + clocks = <&ehrpwm1_tbclk>; > >> + clock-names = "tbclk"; > >> + status = "disabled"; > >> + }; > >> + > >> + ecap1: ecap@48440100 { > > This also is a PWM? Then it should also be pwm@... > > The enhanced capture module primary purpose is to measure > time between external signals which is called capture mode. > It also has a PWM mode. So I wouldn't recommend generalizing > the entire node to pwm. So is this patch safe for me to apply now or do we need more changes? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html