Hi Tomeu, Dinh, Andreas
I need a sum and help from you to go ahead on the
tx timeout.
The "stmmac: MDIO fixes" seems to be the candidate to
fix the phy connection and I will send the V2 asap (Andreas' comment).
So, supposing the probe is ok and phy is connected,
I need your input ...
Tomeu: after revering the 0e80bdc9a72d (stmmac: first frame
prep at the end of xmit routine) the network is
not stable and there is a timeout after a while.
The box has 3.50 with normal desc settings.
Dinh: the network is ok, I wonder if you can share a boot
log just to understand if the normal or enhanced
descriptors are used.
Andreas: you are also using 3.50 with normal desc but I have not
clear if just reverting 0e80bdc9a72d commit the
network is ok or you see timeout issues.
In the meantime I am trying to find a box where try normal setup
and I can confirm that enhanced descriptors are ok on my side
Regards
Peppe
On 3/9/2016 3:31 PM, Giuseppe CAVALLARO wrote:
Hi Tomeu
On 3/9/2016 11:53 AM, Tomeu Vizoso wrote:
On 9 March 2016 at 11:27, Giuseppe CAVALLARO <peppe.cavallaro@xxxxxx>
wrote:
Hello Tomeu, Andreas,
On 3/9/2016 10:52 AM, Giuseppe CAVALLARO wrote:
* today's linux-next: probe failed
* today's linux-next + revert of 88f8b1bb41c6 stmmac: Fix 'eth0: No
PHY found' regression: probe succeeded but no network at all
* today's linux-next + revert of 88f8b1bb41c6 (stmmac: Fix 'eth0: No
PHY found' regression) + revert of 0e80bdc9a72d (stmmac: first frame
prep at the end of xmit routine): probe succeeded, dhcp succeeds and
nfsroot works for a few seconds before timing out
ok, I was looking at this problem now that seems to related
the "stmmac: first frame prep at the end of xmit routine"
that, at first glance, is breaking the gmac 3.50 with normal
descriptor.
I have no Hw where to test this use case. So, I wonder if may I ask
you to
test some patch.
This first patch adds a missing barrier to the normal routine that
inits the
descriptor. Barrier was needed to well manage the OWN
descriptor and it was not added in case of normal desc case after
the xmit rework.
Then I will check the algo behind the new xmit and in case of problems,
if you agree, we will decide to revert it because it aimed to add an
optimization.
Let me know if you agree.
I'm not sure what you would like to be tested, but just in case, I
have just tried your patch on top of these commits and the result is
the "transmit queue 0 timed out" error during boot:
6542b30d0a67 Revert "stmmac: first frame prep at the end of xmit routine"
eb5274cbc0f7 Revert "stmmac: do not poll phy handler when attach a
switch"
e88e625a68d9 Revert "stmmac: fix phy init when attached to a phy"
ef5dd3777876 stmmac: fix MDIO settings
77634ba1f25c Revert "stmmac: Fix 'eth0: No PHY found' regression"
7811b4ffc312 Add linux-next specific files for 20160309
I missed that the issue is not only related the
"stmmac: first frame prep at the end of xmit routine"
I have to try to test on 3.50 with normal descriptor.
When using enhanced descriptors all works fine on my
side.
I keep you informed.
peppe
Regards,
Tomeu
Regards
Peppe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
