Re: [PATCH] aespipe - fix build issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/6/08, Jari Ruusu <jariruusu@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Alon Bar-Lev wrote:
>  > OK, I will make them available again once all the other is setup.
>  > The problem is that it always link the project if you make x86...
>
>
> At least for me that is not a problem. This how I test it:
>
>     make x86
>      <run some tests>
>     make aespipe
>      <run some tests>
>      <realize that I forgot some tests>
>     make x86
>      <run more tests>
>     make aespipe
>      <run more tests>

I mean the following, twice make will twice link .
$ make
gcc  -o aespipe aespipe.o aes-x86.o md5-x86.o sha512.o rmd160.o
 $ make
gcc  -o aespipe aespipe.o aes-x86.o md5-x86.o sha512.o rmd160.o

> "make aespipe" target has been there for a long time. Breaking existing
>  build scripts is not cool, so I prefer to keep it as it is.

OK... but it was a mistake to call it by the executable name...

> Merged most of configure.ac bits. Dropped most of Makefile.in bits.
>  VPATH=@srcdir@ in Makefile is not portable. x86/amd64 detection is still
>  using $CC wrapped 'ld --verbose' as it was in build4. That is because it
>  provides much better guarantee that there is GNU binutils/assembler
>  underneath. Automatically enabling x86/amd64 on other assemblers is a little
>  bit risky.

I am happy now!
Thank you!

Now, few remaining issues:

1. What do you want to do with bz2aespipe? Should make install also
install it? Should users of this package (on distributions) be able to
use it without manually obtaining the tarball?

2. initramfs configuration may use static link by adding
LDFLAGS="-static", the problem is that you are using getowuid() in
aespipe which is not static friendly. One solution is to add
--enable-something in order to disable the unfriendly functionality,
other is to add a preprocessor condition and allow externally disable
this.

Thank you,
Alon.

-
Linux-crypto:  cryptography in and on the Linux system
Archive:       http://mail.nl.linux.org/linux-crypto/


[Index of Archives]     [Kernel]     [Linux Crypto]     [Gnu Crypto]     [Gnu Classpath]     [Netfilter]     [Bugtraq]
  Powered by Linux