Re: [PATCH] aespipe - fix build issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/4/08, Jari Ruusu <jariruusu@xxxxxxxxxxxxxxxxxxxxx> wrote:
>  - These make targets must stay:
>     make aespipe    (always C language regardless of auto-detection)
>     make x86        (always x86 asm regardless of auto-detection)
>     make amd64      (always amd64 asm regardless of auto-detection)

OK, I will make them available again once all the other is setup.
The problem is that it always link the project if you make x86...
Can the aespipe be converted to generic so we have sane rules?
I took another approach please have a look at build6.

>  - Your Makefile is shorter, but it is less hackable. When coding and
>   debugging problems, I change compile options for each file individually.
>   Some get -S or -DFOO options and such, and then I look at generated code.
>   Having all sources under one or two "generic" rules is pure PITA. Remember
>   when I said that I don't like automake with its un-hackable Makefile? You
>   are trying to make it unhackable. Not good, IMO.

I disagree... The shorter makefile is much clearer... If there is a
need for customization a special rule may be written.
But it is your project... :)
As you merged the build4, it is difficult to know in which state you are.
The attached is since your last snapshot.
I hope it is more appropriate. I changed the "aespipe" to "generic" so
that the rules will be consistant.

>  - Other improvements look ok. I will look at it more closely tomorrow.

Thank you,
Alon.

Attachment: aespipe-v2.3d-build6.patch.bz2
Description: BZip2 compressed data


[Index of Archives]     [Kernel]     [Linux Crypto]     [Gnu Crypto]     [Gnu Classpath]     [Netfilter]     [Bugtraq]
  Powered by Linux