Alon Bar-Lev wrote:
> +install-strip:
> + if ! test -f aespipe ; then $(MAKE) all ; fi
> + $(MAKE) INSTALL_STRIP=$(STRIP) install
>
> Why do you need make all here? The make install will do this, right?
My mistake.
> 2. You cannot use uname at configure, as it won't work with you cross compile.
> This is what started this thread... :)
Right.
> 3. You cannot use as... As it would fail cross compile.
Right.
> I Also fixed some more autoconf issues, please review.
I merged your patch (aespipe-v2.3d-build4.patch).
I also dropped #if defined()... wrapper from exec-stack configure.ac test.
Intention is to test if assember accepts that section, not hide interesting
part from assembler.
I also changed the section from
.section .note.GNU-stack,"",%progbits
^
to
.section .note.GNU-stack,"",@progbits
^
because that is what gnu assember documentation says. That change also made
older versions of assembler accept it without choking. Oldest assember I
tested it with appears to be from year 1997.
> Opps... Forgot the patch.
Notes about aespipe-v2.3d-build5.patch :
- These make targets must stay:
make aespipe (always C language regardless of auto-detection)
make x86 (always x86 asm regardless of auto-detection)
make amd64 (always amd64 asm regardless of auto-detection)
- Your Makefile is shorter, but it is less hackable. When coding and
debugging problems, I change compile options for each file individually.
Some get -S or -DFOO options and such, and then I look at generated code.
Having all sources under one or two "generic" rules is pure PITA. Remember
when I said that I don't like automake with its un-hackable Makefile? You
are trying to make it unhackable. Not good, IMO.
- Other improvements look ok. I will look at it more closely tomorrow.
--
Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD
-
Linux-crypto: cryptography in and on the Linux system
Archive: http://mail.nl.linux.org/linux-crypto/
