Re: [PATCH] aespipe - fix build issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alon Bar-Lev wrote:
> 1. What you are doing with Makefile to remove escape is ugly! and
> highly none standard.

I am not removing escapes, I am changing " " to "\ " in srcdir variable.

When I saw you sprinkling quotes around variables containing path names, I
figured that you are trying to make it work with path names that have spaces
in them. Ok, fine. I actually tested it with srcdir having spaces. Here is
what I learned: configure script created using autoconf-2.61, which is the
default in my workstation, created script that failed with spaces in srcdir.
Installed newer autoconf-2.63, which appears to be the latest released one,
created configure script that runs ok, but make chokes on source
dependencies that have spaces. Thus the ugly "massaging" of Makefile srcdir
variable.

Try building aespipe so that:

"/tmp/ 1 " is the source directory
"/tmp/ 2 " is the build directory
"/tmp/ 3 " is the installation root directory

$ cd "/tmp/ 2 "
$ "/tmp/ 1 /configure" && make install DESTDIR="/tmp/ 3 "
$ make tests

Try that using a "standard" srcdir definition in Makefile.in, as in:

srcdir = @srcdir@

> 2. I lost you... Can you please send full configure.ac and Makefile.in

Attached.

> 3. Please don't strip in working directory, as subsequent make install
> without strip will be affected.

My bad.

> 4. I believe that users (including myself) expect that autoconf
> packages will not require special targets to build and install.
> "./configure && make install" should be sufficient and perform all
> required detection. So extra effort should be invested n order to
> detect optimization required. I can test for the assembly success if
> you like.

It doesn't have to be "full" CPU type detection. Maybe detecting x86/amd64
on GNU tool chain is enough, and let everyone else default to C source.

-- 
Jari Ruusu  1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9  DB 1D EB E3 24 0E A9 DD

Attachment: Makefile.in.bz2
Description: Binary data

Attachment: configure.ac.bz2
Description: Binary data


[Index of Archives]     [Kernel]     [Linux Crypto]     [Gnu Crypto]     [Gnu Classpath]     [Netfilter]     [Bugtraq]
  Powered by Linux