Fabio M. Di Nitto napsal(a): > On 10/29/2012 08:44 PM, Angus Salkeld wrote: >> On 25/10/12 15:25 +0200, Fabio M. Di Nitto wrote: >>> Hi Jacek, >>> >>> On 10/25/2012 2:49 PM, Jacek Konieczny wrote: >>>> On Thu, Oct 25, 2012 at 10:01:03AM +0200, Fabio M. Di Nitto wrote: >>>>> Which symbols are we talking about? >>>>> >>>>> do you have a list? >>>>> >>>>> In theory libtotem_pg should never use libqb directly >>>> >>>> Searching for shared objects with unresolved symbols... >>>> Unresolved symbols found in: >>>> /home/users/jajcus/tmp/corosync-2.1.0-root-jajcus/usr/lib/libtotem_pg.so.5.0.0 >>>> >>>> qb_loop_poll_del >>>> qb_strerror_r >>>> qb_util_nano_current_get >>>> qb_loop_timer_add >>>> qb_loop_poll_add >>>> qb_loop_timer_del >>>> DONE >>> >>> thanks, you are absolutely right. >>> >>> libtotem_pg must link with link with libqb. >>> >>> Angus: perhaps this change could make other parts of totem easier? like >>> logging for example? >> >> Maybe a little, but I think Steve had some reasons for making totem >> as much as possible a standalone lib. > > Yes, the original reason Steven had was to avoid linking against any > external libraries. now, this is not the case anymore as we _must_ link > with libqb and there for there is no reason to avoid using it properly > if that can avoid other complexities. Yes. In flatiron components were: - totem = totem(srp|udp|udpu|pg|...) + coropoll - logging system - used by corosync, and passed to totem by callbacks - services - they were using coropoll thru coroapi Now, coropoll and logging system is in one library, so it seems to be NICE idea to drop passing logging functions. On the other hand, let's say somebody wants to use libtotem itself (I'm aware exactly about 0 projects in whole history of OpenAIS/Corosync doing it that way), with it's own logging system. In that case, it's better to stand as we are now. So my proposal is: - Needle needs to stay compatible - no changes there - TODO for 3.0 > > Fabio > Honza _______________________________________________ discuss mailing list discuss@xxxxxxxxxxxx http://lists.corosync.org/mailman/listinfo/discuss
