Re: [PATCH] link libtotem_pg to libqb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Which symbols are we talking about?

do you have a list?

In theory libtotem_pg should never use libqb directly

Fabio

On 10/25/2012 9:44 AM, Jacek Konieczny wrote:
> The libtotem_pg library uses symbols from libqb, so it should be
> explicitely linked with it. This doesn't cause problems for corosync
> binary itself, as it is linked to both libraries, but can cause
> problems if anything else links to libtotem_pg.so and automated
> checkers can show this as a library problem.
> ---
>  exec/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exec/Makefile.am b/exec/Makefile.am
> index 2cc4f47..5c5df4e 100644
> --- a/exec/Makefile.am
> +++ b/exec/Makefile.am
> @@ -50,7 +50,7 @@ lib_LTLIBRARIES		= libtotem_pg.la
>  libtotem_pg_la_SOURCES	= $(TOTEM_SRC)
>  libtotem_pg_la_CFLAGS	= $(nss_CFLAGS) $(rdmacm_CFLAGS) $(ibverbs_CFLAGS)
>  libtotem_pg_la_LDFLAGS	= -version-number $(subst .,:,$(SONAME))
> -libtotem_pg_la_LIBADD	= -lpthread $(nss_LIBS) $(rdmacm_LIBS) $(ibverbs_LIBS)
> +libtotem_pg_la_LIBADD	= -lpthread $(LIBQB_LIBS) $(nss_LIBS) $(rdmacm_LIBS) $(ibverbs_LIBS)
>  
>  sbin_PROGRAMS		= corosync
>  
> 

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux