Re: rgw: S3 bucket notification for Copy and CompleteMultipartUpload is missing metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Yuval,

I'd also like to thank you for the quick response and fix!

Thanks & kind regards,
Thilo

On Mon, Nov 14, 2022 at 5:05 PM Yuval Lifshitz <ylifshit@xxxxxxxxxx> wrote:

> Thilo and Stefan,
> Thanks for your help!
> Both fixes are now under review;
> https://github.com/ceph/ceph/pull/48875
> https://github.com/ceph/ceph/pull/48877
>
> it might take a little longer, but the fixes should also be backported to
> quincy.
>
> Yuval
>
> On Mon, Nov 14, 2022 at 11:50 AM Yuval Lifshitz <ylifshit@xxxxxxxxxx>
> wrote:
>
>> this is just to remove the prefix that we add as we store metadata as an
>> object attribute.
>> for example, if there is an attribute named:
>> "rgw.user.x-amz-meta-somemetadata"
>> we want the filter rule to use the original metadata key:
>> "x-amz-meta-somemetadata".
>>
>>
>> On Mon, Nov 14, 2022 at 11:15 AM Thilo-Alexander Ginkel <thilo@xxxxxxxxxx>
>> wrote:
>>
>>> Hello Yuval,
>>>
>>> On Sun, Nov 13, 2022 at 10:24 AM Yuval Lifshitz <ylifshit@xxxxxxxxxx>
>>> wrote:
>>>
>>>> The issue was indeed fixed (both with regard to filtering and sending
>>>> the metadata) in the tracker that you mentioned but was broken by another
>>>> fix (https://github.com/ceph/ceph/pull/39192) :-(
>>>> I will re-apply the fix (and make sure we regression tests, so it does
>>>> not break again).
>>>>
>>>
>>> thanks for your reply and thanks for fixing this issue! Just one
>>> (somewhat unrelated) question regarding how notifications are intended to
>>> work. Looking at the code of metadata_from_attributes (in rgw_notify.cc) I
>>> see a filter for a "rgw.user.meta-" (RGW_ATTR_META_PREFIX) prefix. Is this
>>> just dealing with how metadata is stored internally or will this filter out
>>> any metadata whose key does not start with "rgw.user.meta-"?
>>>
>>> Thanks,
>>> Thilo
>>>
>>
_______________________________________________
ceph-users mailing list -- ceph-users@xxxxxxx
To unsubscribe send an email to ceph-users-leave@xxxxxxx



[Index of Archives]     [Information on CEPH]     [Linux Filesystem Development]     [Ceph Development]     [Ceph Large]     [Ceph Dev]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [xfs]


  Powered by Linux