On Wed, 20 Mar 2019 04:15:04 +0000 (UTC), Sage Weil wrote: > > I've added a virtual ceph.snap.timestamp=$secs.$nsecs xattr to the > > CInode::encode_inodestat() code path on the MDS: > > https://github.com/ddiss/ceph/commit/6825ba361d32a295d96fdf387965f04198b95ad1 > > > > I've also added corresponding Samba functionality to fetch this during > > .snaps readdir(). Please let me know whether you think this is the right > > spot for this, or whether the vxattr should be processed on the client > > side and translated into a different (new) MDS request which explicitly > > grabs SnapInfo.stamp. > > I think the vxattrs should definitely be processed/handled on the client > side. > > As far as how the metadata gets there, I'd try to include it in an > existing nsap structure (SnapInfo?) so that there is no need for any > additional request, which will add complexity. Okay I'll go down that route. At this stage I'm pretty lost as to how I can add the snap timestamp to an existing wire struct without revving the protocol version or adding a new operation. Any tips would be greatly appreciated. Cheers, David
