On Wed, 25 Oct 2017, Josh Durgin wrote:
At this point it it seems worth finally separating the internal and
external types there, without doing a full new version of librados.
+1
Even though it looks like we won't move forward on too many extravagant
things (as per the etherpad, "http://pad.ceph.com/p/librados3";), I do
still have one wishlist item I should throw in here: If we could enable a
CephContext can live on the stack while we're in here, that would be
awesome. Does anyone know why it's dtor has been made private?
It may be possible to do this without introducing a new type, by freezing the
existing bufferlist as the external type for librados and librbd, and making
a conversion if necessary. We could add a true pimpl wrapper as a new type to
avoid the overhead of conversion if it is a problem.
Assuming the doesn't preclude adding other future types, seems like a
reasonable way to address the situation. The PIMPL will still have some
overhead from the indirection, but certainly less than forcing
conversion/copy.
-Jesse
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
