On Thu, Dec 15, 2016 at 3:54 PM, Jason Dillaman <jdillama@xxxxxxxxxx> wrote: > Correct me if I am wrong, but since we are just installing RPMs, I > wouldn't expect the full source tree to be available on the test host. > The test scripts would still need to pull the correct scripts from > git. Preferably, it would be nice if we can get a new environment > variable that includes the full git url with the branch/sha1 already > embedded. That would allow testing any script changes on teuthology > w/o forcing a push to ceph-ci and creating an unnecessary build. I'm thinking that rather than teuthology (the process executing workunit.py) calling a git command on the test host, it would take its local copy of the script (i.e. relative to workunit.py ../../../qa/workunits etc) and send that directly. I think we can already avoid pushing test-only changes to ceph-ci, because there are separate options for ceph vs. suite branches (even though both point at ceph.git forks). So when I want to test a qa-suite change, I would use --suite-repo <github /jcsp/ path> --suite-branch wip-whatever. That would get the workunits from wip-whatever. John > > On Thu, Dec 15, 2016 at 10:46 AM, John Spray <jspray@xxxxxxxxxx> wrote: >> On Thu, Dec 15, 2016 at 3:00 PM, Mykola Golub <trociny@xxxxxxxxxxx> wrote: >>> On Thu, Dec 15, 2016 at 04:51:44PM +0200, Mikolaj Golub wrote: >>>> Hi, Sage, >>>> >>>> It looks like we still need to push testing branches to ceph.git for >>>> things like below? >>>> >>>> qa/workunits/rbd/test_librbd_python.sh: >>>> >>>> wget -O test_rbd.py "https://git.ceph.com/?p=ceph.git;a=blob_plain;hb=$CEPH_REF;f=src/test/pybind/test_rbd.py"; || \ >>>> wget -O test_rbd.py "https://git.ceph.com/?p=ceph.git;a=blob_plain;hb=ref/heads/$CEPH_REF;f=src/test/pybind/test_rbd.py"; >>>> >>>> Do we have some env variable (CEPH_REPO?) we could use simirlaly to >>>> CEPH_REF here? >>> >>> Or rather may be now we can avoid such hacks at all? >> >> Exactly - as you notice bits like that, let's convert them to just >> read their files locally instead of trying to fetch them from git. I >> guess the workunit task will be the major one here, if nobody already >> adjusted it. >> >> John >> >>> -- >>> Mykola Golub >>> -- >>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> _______________________________________________ >> Sepia mailing list >> Sepia@xxxxxxxxxxxxxx >> http://lists.ceph.com/listinfo.cgi/sepia-ceph.com > > > > -- > Jason -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
