On 05/20/2016 03:01 PM, Owen Synge wrote: > On 05/12/2016 03:06 PM, Sage Weil wrote: >> On Mon, 11 Apr 2016, Owen Synge wrote: >>> On 04/08/2016 10:57 PM, Owen Synge wrote: >>>> On 04/07/2016 05:43 PM, Sage Weil wrote: >>>>> On Thu, 7 Apr 2016, Owen Synge wrote: >>>>>> On 04/07/2016 04:03 PM, Sage Weil wrote: >>>>>>> On Thu, 7 Apr 2016, Owen Synge wrote: >>>>>>>> Hi Sage, >>>>>>>> >>>>>>>> On 04/07/2016 02:26 PM, Sage Weil wrote: >>>>>>>>> Hi Owen, >>>>>>>>> >>>>>>>>> I never really liked ceph-create-keys either, but it simplified the >>>>>>>>> deployment process. >>>>>>>> >>>>>>>> I would propose we do this in two stages. >>>>>>>> >>>>>>>> (A) Remove calling the command from the init scripts as a side effect of >>>>>>>> starting the mon. >>>>>>>> >>>>>>>> This allows us to get most of the issues solved. >>>>>>>> >>>>>>>> (B) Remove the command. >>>>>>>> >>>>>>>> This is the long term goal, which is not as urgent in my opinion but >>>>>>>> others may disagree. >>>>>>> >>>>>>> Works for me. We just need to change ceph-deploy and get the other >>>>>>> install/deploy tool folks on board before A. >>>>>> >>>>>> Are you intending to get this into Jewel? >>>>>> >>>>>> I had assumed this would only be done on master, and only come into the >>>>>> next release. >>>>> >>>>> Yeah, too late for jewel. >>>>> >>>>>> As a change to master I felt that we could just do (A) as soon as >>>>>> ceph-deploy works without the mon boot up scripts calling >>>>>> ceph-create-keys, ideally without having ceph-create-keys in >>>>>> ceph-deploy's process. >>>>>> >>>>>> We can then file bugs as needed against other install processes that >>>>>> depend on ceph-create-keys, and they can test against master. >>>>> >>>>> That works for me. >>>>> >>>>> sage >>>> >>>> Great, >>>> >>>> I have a fix, that is tested and working for ceph-deploy without >>>> depending upon ceph-create-keys based upon a rewrite of the method >>>> >>>> ceph-deploy gatherkeys mon-node-01 mon-node-02 mon-node-03 >>>> >>>> Works nicely for the old and new methods, and seems to have little >>>> impact apart from no new keys are wrote to disk on the mon nodes. OSD's >>>> and rgw can be deployed without change, (I haven’t tested mds) >>>> >>>> Previous behavior with the admin keys being deployed can be achieved >>>> simply by executing: >>>> >>>> ceph-deploy admin mon-node-01 mon-node-02 mon-node-03 >>>> >>>> If we definitely what to enforce the admin code being persisted on all >>>> mon nodes can be changed later, but I think its cleaner if we do not. >>>> >>>> I will submit a PR on Monday. >>> >>> ceph-deploy bug raised: >>> >>> http://tracker.ceph.com/issues/15451 >>> >>> PR submitted: >>> >>> https://github.com/ceph/ceph-deploy/pull/393 >> >> Hey Owen- >> >> Now that jewel is out, now would be a good time to make this change. The >> ceph-deploy pr looks basically ready to go, minus a doc piece and a run >> through the ceph-deploy suite. Yuri can probably handle the >> latter. >> >> Then we can do the ceph.git changes to kill the ceph-create-keys task... > > Dear Sage, > > Sorry for the delay, I had a big pile of downstream work and test suite > development to do for my salt work, I have now added some documentation. > > I hope Yuri can do the latter as I really dont know "the ceph-deploy suite". Great news ceph-deploy master now has the PR merged in so that ceph-deploy can now work without any magic involved with ceph-create-keys. I will now make a patch to ceph proper to remove ceph-create-keys from the init scripts. Hopefully this will move things forward and we can get this patch merged relatively quickly. Please let me know if I am doing anything wrong. Best regards Owen -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
