On 2016-04-07T12:31:21, Sebastien Han <shan@xxxxxxxxxx> wrote:
> One thing I'd like to see and I know we discussed that with Loïc a
> while ago is ceph-disk being idempotent when it comes to the device
> preparation.
> Running "ceph-disk prepare" against a device should result in an exit
> 0 if the disk already has an OSD prepared on it (unless we do
> something like --force, which will then zap the disk).
> I had to implement this logic in ceph-ansible (and the guys from
> chef/puppet probably did the same), so now it's done but i'll be happy
> to leave ceph-disk doing it :).
>
> Thoughts?
Basically, +1.
Owen (who works on salt-ceph) has a love/love relationship with the word
"idempotent" as well.
Note that it should probably only exit=0 if the OSD matches the current
fsid?
Regards,
Lars
--
Architect SDS, Distinguished Engineer
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
