Re: [alsa-cvslog] alsa-kernel: fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon, 21 Aug 2006 09:52:05 +0200,
Clemens Ladisch wrote:
> 
> Takashi Iwai wrote:
> > [...]
> > I meant CONFIG_SND_FM801_TEA575X in the external alsa-driver tree is
> > never set to y or m.  It's always n.  This is because
> > CONFIG_SND_FM801_TEA575X is evaluated before *_TEA575X_BOOL.
> 
> Okay, I reverted my Kconfig change.
> 
> I tried to use this patch to manually evaluate the TEA575X symbols:
> 
> --- alsa.orig/alsa-driver/configure.in	2006-08-20 11:38:22.000000000 +0200
> +++ alsa/alsa-driver/configure.in	2006-08-21 01:04:13.000000000 +0200
> @@ -2548,6 +2548,14 @@
>  CONFIG_SOUND=m
>  ALSA_TOPLEVEL_SELECT
>  
> +dnl Workaround for module->option dependency
> +if ( test "$CONFIG_SND_FM801_TEA575X_BOOL" = "y" ) &&
> +   ( test "$CONFIG_VIDEO_DEV" = "y" ); then
> +  CONFIG_SND_FM801_TEA575X="m"
> +else
> +  CONFIG_SND_FM801_TEA575X_BOOL=""
> +fi
> +
>  dnl OSS emulations
>  if test "$CONFIG_SND_OSSEMUL" = "y"; then
>    CONFIG_SND_MIXER_OSS="$CONFIG_SND"
> 
> 
> However, this results in include/config1.h and toplevel.config being
> inconsistent.  Apparently, autoconf writes the symbols to config1.h when
> AC_DEFINE is called, but writes to toplevel.config when AC_SUBST is
> called.  This means that the above workaround gets applied after
> config1.h was written.
> 
> The obvious solution would be to move the AC_DEFINE()s out of
> ALSA_TOPLEVEL_SELECT into a new macro or into ALSA_TOPLEVEL_OUTPUT.
> However, this may also change the values of the OSS symbols that are
> written to config1.h (which is done before the assignments under "OSS
> emulations"), and I'm not sure if this change might break anything.

I think it's a bug that config1.h is written before any manual
modifications like configs for OSS emulation.  We should move writes
to config1.h to a later stage as you suggested.


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux