Takashi Iwai wrote: > Clemens Ladisch wrote: > > Takashi Iwai wrote: > > > Clemens Ladisch wrote: > > > > files: pci/Kconfig > > > > description: > > > > fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL > > > > > > > > Move the CONFIG_VIDEO_DEV dependency from CONFIG_SND_FM801_TEA575X to > > > > CONFIG_SND_FM801_TEA575X_BOOL so that the two symbol always have > > > > consistent values even when compiled externally. > > > > > > Is it a really correct fix? > > > It looks like that this forces CONFIG_VIDEO_DEV=y even though it's not > > > necessarily so. > > > > Uh, yes. > > > > I guess a better fix would be to change the code to not look at > > CONFIG_SND_FM801_TEA575X_BOOL at all. > > Well, CONFIG_SND_FM801_TEA575X_BOOL was introduced exactly for the > purpose to fix the messy dependency in Kconfig, so it is apparently > correct (e.g. CONFIG_VIDEO_DEV has to be y if FM801 is y). But when compiling externally when CONFIG_VIDEO_DEV isn't set, CONFIG_SND_FM801_TEA575X will not be set although CONFIG_SND_FM801_TEA575X_BOOL is set. This will result in undefined references in snd-fm801 because it thinks that it can use the tuner functions. > > I'll revert this one and do the change I proposed above over the weekend > > unless anybody objects. > > I think we can keep it as it is. > This is a bug, of course, but can be avoided by specifying configure > options. That is, I should list all card drivers/options except this one? ;-) > Or, just make a temporary patch for fm801.c to add additional ifdef > check around > > #ifdef CONFIG_SND_FM801_TEA575X_BOOL > #include <sound/tea575x-tuner.h> > #define TEA575X_RADIO 1 > #endif > > until we fix configure stuff. Okay, I'll do this. Regards, Clemens ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
