At Fri, 18 Aug 2006 10:56:22 +0200,
Clemens Ladisch wrote:
>
> Takashi Iwai wrote:
> > Clemens Ladisch wrote:
> > > files: pci/Kconfig
> > > description:
> > > fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL
> > >
> > > Move the CONFIG_VIDEO_DEV dependency from CONFIG_SND_FM801_TEA575X to
> > > CONFIG_SND_FM801_TEA575X_BOOL so that the two symbol always have
> > > consistent values even when compiled externally.
> >
> > Is it a really correct fix?
> > It looks like that this forces CONFIG_VIDEO_DEV=y even though it's not
> > necessarily so.
>
> Uh, yes.
>
> I guess a better fix would be to change the code to not look at
> CONFIG_SND_FM801_TEA575X_BOOL at all.
Well, CONFIG_SND_FM801_TEA575X_BOOL was introduced exactly for the
purpose to fix the messy dependency in Kconfig, so it is apparently
correct (e.g. CONFIG_VIDEO_DEV has to be y if FM801 is y).
> > The problem in alsa-driver's build is that SND_FM801_TEA575X_BOOL is
> > evaluated after SND_FM801 and SND_FM801_TEA575X because the former is
> > an option. In acinclude.m4, the whole checks of options are done
> > after cards.
> >
> > Maybe a better way would be to change acinclude.m4 like:
> >
> > CARDS="xxx yyy ..."
> > OPTIONS="aaa bbb ..."
> >
> > ac_snd_config_exists () {
> > # check whether $1 is in cards or options
> > }
> >
> > # then check each card/option in the order appearing in
> > # Kconfig
> > if ac_snd_config_exists ad1816a; then
> > ....
> > fi
> > if ac_snd_config_exists ad1816a; then
> > ....
> > fi
>
> I'm not sure it would be a good idea to rewrite all this just before
> the .12 release.
Yep, that's why I didn't touch it yet ;)
> I'll revert this one and do the change I proposed above over the weekend
> unless anybody objects.
I think we can keep it as it is.
This is a bug, of course, but can be avoided by specifying configure
options.
Or, just make a temporary patch for fm801.c to add additional ifdef
check around
#ifdef CONFIG_SND_FM801_TEA575X_BOOL
#include <sound/tea575x-tuner.h>
#define TEA575X_RADIO 1
#endif
until we fix configure stuff.
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
