Re: [alsa-cvslog] alsa-kernel: fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 18 Aug 2006 09:24:25 +0200 (CEST),
Clemens Ladisch wrote:
> 
> changeset:   4451:4d657e2f7e7c42933fad6c884535cc30e751a782
> tag:         tip
> user:        cladisch
> date:        Fri Aug 18 09:04:41 2006 +0200
> files:       pci/Kconfig
> description:
> fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL
> 
> Move the CONFIG_VIDEO_DEV dependency from CONFIG_SND_FM801_TEA575X to
> CONFIG_SND_FM801_TEA575X_BOOL so that the two symbol always have
> consistent values even when compiled externally.

Is it a really correct fix?
It looks like that this forces CONFIG_VIDEO_DEV=y even though it's not
necessarily so.

The problem in alsa-driver's build is that SND_FM801_TEA575X_BOOL is
evaluated after SND_FM801 and SND_FM801_TEA575X because the former is
an option.  In acinclude.m4, the whole checks of options are done
after cards.

Maybe a better way would be to change acinclude.m4 like:

	CARDS="xxx yyy ..."
	OPTIONS="aaa bbb ..."

	ac_snd_config_exists () {
		# check whether $1 is in cards or options
	}

	# then check each card/option in the order appearing in
	# Kconfig
	if ac_snd_config_exists ad1816a; then
		....
	fi
	if ac_snd_config_exists ad1816a; then
		....
	fi


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux