At Wed, 21 Jun 2006 23:20:29 -0700, Sam Revitch wrote: > > On 6/20/06, Takashi Iwai <tiwai@xxxxxxx> wrote: > > The patch still has a problem with ac97_codec.c that has also own > > lowlevel device. opl3 and opl4 have to be fixed. > > > > Looking through the patch, I found that unregister callback can be > > replaced simply with disconnect + free. This will remove the > > complexity a bit. I'll try to make another patch based on yours. > > Thanks for looking at this and fixing it, and sorry to take so long to > get back to ya. I tried out the patch that you sent out earlier and > it definitely behaves correctly when pulling cables with my USB card > and also seems to pass the alsasound restart loop test. Eliminating > dev_unregister seems appropriate, as dev_disconnect was being called > every time anyway and the former certainly became redundant. IMHO the > patch you sent is complete or very close. Good. I'll commit it (splitted to separate patches) to HG repo later after releasing 1.0.12rc1. Also snd_card_free_in_thread() will be replaced with snd_card_free_when_closed(). thanks, Takashi All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
