Hello Peter, On 5/12/20 8:33 AM, Peter Krempa wrote: > Well, you certainly can contribute in having them merged. Even testing > is a contribution. > [..] > Well, for us that means that we don't have anybody willing to give input > on the feature. I don't have experience nor hardware for testing it [..]. I also have only one capable host left, but no counterpart to test with. Other hardware is either running in production environment or reserved for emergencies. > Depends on the status of the patches. I've reviewed them yesterday and I > don't agree with the design. If you have more knowledge of how those > things work, even explaining them is a contribution to possbily adding > the feature. I mean it is kind of tricky to implement, since iSER sits somewhat between the iSCSI protocol and different transport methods. Maybe implementing it as its own protocol capable of communicating over different transport methods (RoCE, Infiniband, etc. (NOT: RDMA)) is the way to go. I think the author simply tried to adapt it to the implementation in qemu as best as he could to avoid self inflicting head wounds with his keyboard during alteration of the libvirt qemu driver. Kind regards, David
Attachment:
signature.asc
Description: OpenPGP digital signature
