On Thu, Oct 20, 2016 at 12:40:29AM -0000, Josh Boyer wrote:
> > On Wed, Oct 19, 2016 at 11:13:25AM -0600, Kevin Fenzi wrote:
> >
> > That can very well be and I missed it, so let's please s/secondary/alternative/g
> > here :)
>
> Please!
I'll rename and adjust the file if/when we'll all be ok with it (I'm fine with
re-sending it for review then).
> > The hook will point out any commit that is touching either ExclusiveArch or
> > ExcludesArch, regardless of the arch impacted.
> > There will be false-positive for sure (for example epel packages introduced in
> > certain arch which doesn't exist in RHEL).
>
> Can the hook exclude anything in EPEL?
Sure, this should do it:
diff --git a/ roles/git/hooks/files/post-receive-secondaryarch b/ roles/git/hooks/files/post-receive-secondaryarch
index 9ad165f..189c69c 100755
--- a/ roles/git/hooks/files/post-receive-secondaryarch
+++ b/ roles/git/hooks/files/post-receive-secondaryarch
@@ -147,6 +147,11 @@ def run_as_post_receive_hook():
print('Received:', line.strip())
(oldrev, newrev, refname) = line.strip().split(' ', 2)
+ # Skip all the branches that are not master and do not start with an 'f'
+ # ie: personal branches and epel
+ if not refname.startswith(('refs/heads/master', 'refs/heads/f')):
+ continue
+
new_commits_list = get_revs_between(oldrev, newrev, abspath, refname)
if DEBUG:
print('List of commits:', new_commits_list)
> > Is there an alternative-arch-sig list of some sort?
>
> secondary@xxxxxxxxxxxxxxxxxxxxxxx (ironic, I know). It might be worth looking at migrating that list to alternative-arches or something.
Sounds like a good list for me, are the people interested in these emails
subscribed there? (I suspect they are, but better safe than sorry :))
Pierre
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
