On Sun, Sep 11, 2016 at 05:52:46AM -0700, Christoph Hellwig wrote: > On Thu, Sep 08, 2016 at 04:16:56PM -0700, Darrick J. Wong wrote: > > > Carfeul there - enums are not defined to have a fixed size and so > > > can change from compiler version to compiler version. IOWs, the > > > enum values can be written idirectly to an on-disk structure, but > > > the on-disk structure should not be using the enum as the type > > > definition for whatever gets stored on disk. > > > > <nod> I left the fields (and the #define flags) definitions alone, > > so it's only writing enum values indirectly into a fixed size (u32) > > variable on-disk. > > > > i.e. I'm not using enums in the on-disk structure definitions. > > now add a byte swap for the flags and everything should be fine. > The whole idea of architecture-dependent log items was a horrible > idea, and I still have hopes of fixing it eventually. There are other fields in the CUI/BUI log items that would also need byte swapping. Not so hard to fix now, though fixing the EFI/RUI/everythingelse will have to be part of that future patchset. <shrug> I also have a vague memory of Dave telling me not to worry about making the log item fields arch-independent... --D _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
