On Fri, Jun 24, 2016 at 03:51:57PM +0200, Damien Gombault wrote: > Hi. > > Thank you for the patch. > > The patch fixes simple cases (like my reproducer) but it does not fix > restoration of more complex directory structures : I have tested the > patch on my > real data, it fixes some but not all warnings (a user renamed/moved > a lots of > files and directory between the 2 dumps). > > Here is another testcase which fails (with the patch) : > > mkdir dira > mkdir dira/dirc > touch dira/dirc/filea > mkdir dirb > > . > ├── dira > │ └── dirc > │ └── filea > └── dirb > > Make a level 0 dump. > > mv dirb dira/dirB > mv dira/dirc/ dira/dirB/dirC > touch dira/dirB/dirC/fileb > > . > └── dira > └── dirB > └── dirC > ├── filea > └── fileb Well, yes. I specifically said in the patch description that it doesn't fix those nested dependency cases and that much deeper surgery is needed to handle those cases. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
