On 12/20/15 1:00 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 20 Dec 2015 07:56:36 +0100
>
> The return type "unsigned long" was used by the suffix_kstrtoint()
> function even though it will eventually return a negative error code.
> Improve this implementation detail by using the type "int" instead.
>
> This issue was detected by using the Coccinelle software.
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
yep, looks like an oversight left over from a17164e5
Harmless, because callers only check for non-zero value, but still
worth fixing.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Thanks,
-Eric
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 436b6ef..59c9b7b 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -137,7 +137,7 @@ static const match_table_t tokens = {
> };
>
>
> -STATIC unsigned long
> +STATIC int
> suffix_kstrtoint(char *s, unsigned int base, int *res)
> {
> int last, shift_left_factor = 0, _res;
>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
