Re: Bug#793495: xfsprogs fails to build on debian ppc64el

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 02, 2015 at 03:06:50PM +0200, Daniel Bast wrote:
> > Am 02.08.2015 um 00:52 schrieb Dave Chinner
> > <david@xxxxxxxxxxxxx>:
> > 
> > On Fri, Jul 31, 2015 at 06:57:35PM -0300, Fernando Seiti
> > Furusato wrote:
> >> That error is common when configure is generated using
> >> out-of-date config.guess and config.sub.  The ones that come
> >> with the package are, in fact, old.
> > 
> > config.sub and config.guess are generated by the build, we don't
> > ship them directly from the git repository. Perhaps you are
> > building from a release tarball rather than from a clean git
> > repository working area? Can you confirm this is the case?
> > 
> 
> Just some observations from my side:
> 
> Extracting the released tarball over a clean xfsprogs git repo and
> removing the .gitignore file, then git status reveals:
> 
> Untracked files:
>   (use "git add <file>..." to include in what will be committed)
> 
> 	.gitcensus
> 	aclocal.m4
> 	config.guess
> 	config.sub
> 	configure
> 	install-sh
> 	ltmain.sh
> 	m4/libtool.m4
> 	m4/ltoptions.m4
> 	m4/ltsugar.m4
> 	m4/ltversion.m4
> 	m4/lt~obsolete.m4
> 	po/xfsprogs.pot
> 
> Looks like there are a lot of untracked file. Is this intentional,
> to have potentially auto-generated but un-versioned files in a
> release tarball?

Goes back to 2009:

commit 1eb10ccb85261931d5401adbff11acd2dbc5bf63
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Wed Apr 29 15:32:28 2009 +0200

    keep autoconf-generated files over make distclean
    
    We do want to ship the autoconf-generated files over make distclean and
    pick them up in Makepkgs so that a user compiling the program doesn't
    require autoconf.
    
    For that split up make distclean from make realclean and exclude the
    files we want to keep form the former.
    
    To make this easier to maintain adher to stricter rules of use for
    CONFIGURE and LDIRT.  CONFIGURE now includes all generated files from
    autoconf (or for it like our copied install-sh) and gets only removed
    on make realclean, but added to LSRCFILES so that Makepkgs can pick it
    up.  Everything else than needs to be removed on a realclean gets
    assigned to LDIRT.
    
    Also split up the configure rule into one to generate the configure
    script and one to run it.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Mike Frysinger <vapier@xxxxxxxxxx>

So we've been doing this with release tarballs for more than 6
years - I checked and found these files in the tarballs back to
3.0.1. The above commit is the last commit prior to the release of
3.0.1...

Nowdays, the generated files in the 3.2.4 tarball created via a
'make dist' rule. I run that on an up to date debian unstable box
with autoconfig 2.69 installed to generate the files, so the
question I have is this: why is an up-to-date build box generating
"out of date" configure/m4 scripts? What, exactly, is out of date,
and how do I ensure that the pre-build config files are correctly
up-to-date?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux