On Thu, Nov 15, 2012 at 04:26:50PM -0600, Mark Tinguely wrote: > On 11/15/12 16:01, Dave Chinner wrote: > >On Thu, Nov 15, 2012 at 03:34:36PM -0600, Mark Tinguely wrote: > >>On 11/15/12 15:16, Dave Chinner wrote: > >>>On Thu, Nov 15, 2012 at 03:01:49PM -0600, Mark Tinguely wrote: > >>>>On 11/15/12 14:48, Dave Chinner wrote: > >>>>>On Thu, Nov 15, 2012 at 11:55:47AM -0600, Mark Tinguely wrote: > >>>>>>The xfs_quota program does not generate output with V2 which causes > >>>>>>xfstest 050 to fails. > >>>>> > >>>>>I don't think that has anything to do with this patch orthechange > >>>>>for V2 - V2 only changes quotacheck behaviour, and that doesn't > >>>>>impact xfs_quota behaviour. The test passes just fine here: > >>>>> > >>>>>$ sudo ./check 050 > >>>>>FSTYP -- xfs (debug) > >>>>>PLATFORM -- Linux/x86_64 test-2 3.7.0-rc5-dgc+ > >>>>>MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb > >>>>>MOUNT_OPTIONS -- /dev/vdb /mnt/scratch > >>>>> > >>>>>050 14s ... 15s > >>>>>Ran: 050 > >>>>>Passed all 1 tests > >>>>> > >>>>>So perhaps there's something else going wrong on your machine? > >>> > >>>Curious. There aren't any errors in the syslog/dmesg saying that > >>>buffers failed verification during the quota check runs, are there? > >>>Also, what platform are you testing on? > >> > >>No error message in dmesg nor /var/log/messages > >> > >>This is a x86_64. > >> > >>It is running OSS with most recent commit: > >> > >> commit 579b62faa5fb16ffeeb88cda5e2c4e95730881af > >> > >>Your two series: > >> xfs: fixes for 3.7-rc6 > >> xfs: current queue for 3.8 > >> > >>I added the XFS_SB_VERSION2_CRCBIT attribute to xfsprogs and enabled > >>it in mkfs.xfs and remade the test/scratch filesystems. > > > >That's likely your problem. Why are you testing with this bit set - > >that's to indicate that there are on disk format changes, and none > >of them occur in this patch set. Hence the kernel should be refusing > >to mount any filesystem with that bit set. As such, I'm using a > >standard userspace for all this regression testing, because > >filesystems with the CRC bit should be failed during mount on 3.8. > > > >/me goes looking.... > > > >Ok, the kernel isn't refusing to mount when that bit is set. That's > >a bug in the patch that introduces the CRC bit that I borked when > >splitting it out of a larger patch. I'll send an updated patch (it's > >the xfs: add CRC infrastructure patch). > > > > removing the attribute bit from the filesystem/tools does not change > the failure on 050 with V2 patches. Can you join #xfs on freenode so we can discuss this in realtime? There's way too much latency on email.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
