On Fri, Oct 07, 2011 at 12:54:41PM +1100, Dave Chinner wrote: > Only thing I'm wondering about is whether is should be renamed > xfs_buf_ioerror_alert(), now that it really is a xfs_buf specific > function? That probably is a better name. There are a few other functions in the buffer code that are misnamed like that e.g. xfs_incore and to a lesser extent xfs_bwrite or XFS_bflush. > Also, many of the callers could probably pass __func__ rather than a > manually set string... True. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
