On Thu, 2011-10-06 at 17:06 -0400, Christoph Hellwig wrote: > Instead of passing the block number and mount structure explicitly > get them off the bp and fix make the argument order more natural. > > Also move it to xfs_buf.c and stop printing the device name given > that we already get the fs name as part of xfs_alert, and we know > what device is operates on because of the caller that gets printed. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> I agree on the name change suggestion, possibly to xfs_buf_error_alert(). Also, with just one exception it seems that the "func" argument is simply the name of the calling function. I would favor adding that via passing __func__ in a macro. If distinguishing between the cases in xlog_sync(), xfs_trans_read_buf(), and xfs_zero_remaining_bytes() were important then the line number could be included. Anyway, looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
